[PATCH] D17864: [PGO] Promote indirect calls to conditional direct calls with value-profile

[Rong Xu via llvm-commits]

xur added a comment.

another comments


================
Comment at: lib/Transforms/Instrumentation/IndirectCallPromotion.cpp:428
@@ +427,3 @@
+
+    PHI->addIncoming(V, IndirectCallBB);
+    if (DirectCallBB)
----------------
davidxl wrote:
> Add assert that V is defined in a BB that dominates IndirectCallBB
do you mean V is defined in IndirectCallBB and dominates BB?

we are in the middle of CFG transformation and dominate tree might not be valid.
Is there a cheap way to check? 

why do you think we need to check this? this seems to be obvious (unless the phis are corrupted already).


http://reviews.llvm.org/D17864