[PATCH] D19465: [ELF][MIPS] Move MIPS GOT header generation to the GotSection

[Simon Atanasyan via llvm-commits]

atanasyan added inline comments.

================
Comment at: ELF/OutputSections.cpp:149
@@ -148,3 +148,3 @@
     return false;
-  Sym.GlobalDynIndex = Target->GotHeaderEntriesNum + Entries.size();
+  Sym.GlobalDynIndex = Entries.size();
   // Global Dynamic TLS entries take two GOT slots.
----------------
rafael wrote:
> Won't this produce the wrong result for mips now?
Now LLD does not support MIPS TLS relocations. So this code does not make worse anything.

I have another couple of patches to support MIPS TLS. As an announce - it might sound like a joke but for GOT entries related to TLS relocations MIPS ABI uses almost regular approach with creation of dynamic relocations for each GOT enty etc. But ABI requires to separate these 'regular' TLS related entries from MIPS specific local/global parts of GOT :)


Repository:
  rL LLVM

http://reviews.llvm.org/D19465