[PATCH] D18724: Fixed Dwarf debug info emission to skip DILexicalBlockFile entries

[David Blaikie via llvm-commits]

On Fri, Apr 22, 2016 at 8:49 PM, Duncan P. N. Exon Smith <
dexonsmith at apple.com> wrote:

>
> > On 2016-Apr-13, at 15:07, David Blaikie via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
> >
> > Nah, just go with it - if someone figures out a better name some time we
> can change it then.
> >
> > On Wed, Apr 13, 2016 at 2:18 PM, Amjad Aboud via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
> > aaboud added a comment.
> >
> > > As for names, yeah... be nice if we had a better name for
> LexicalBlockFile - it's not really a LexicalBlock at all, as such. Though I
> suppose we still use them as strict nesting, etc. Meh.
>
> What about DIFileDiscriminator and getNonDiscriminatorScope?
>

Might get confused with DWARF line table discriminators? Though I'm not
wholely opposed.


>
> >
> >
> > David, do you suggest a different name for the function I am adding, or
> you want to change the name of the DILexicalBlockFile?
> > How about these suggested names:
> > getNonFileScope()
> > getRealScope()
> > getSourceLocalScope()
> >
> > Or you prefer other name?
> >
> >
> > http://reviews.llvm.org/D18724
> >
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160425/a3feb7ab/attachment.html>