[PATCH] D19409: [X86] Handle MachineBasicBlock as a memory displacement operand in the LEA optimization pass

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 25 09:45:27 PDT 2016


rnk added a subscriber: rnk.
rnk accepted this revision.
rnk added a reviewer: rnk.
rnk added a comment.
This revision is now accepted and ready to land.

Fix looks good, thanks!


================
Comment at: test/CodeGen/X86/lea-opt-memop-check-1.ll:1
@@ +1,2 @@
+; REQUIRES: asserts
+; RUN: llc < %s -march=x86 -mtriple=i686-pc-win32 | FileCheck %s
----------------
Yes, this is just a file move, but I think we should remove this REQUIRES line so that we run this test in more configurations.

================
Comment at: test/CodeGen/X86/lea-opt-memop-check-2.ll:1
@@ +1,2 @@
+; REQUIRES: asserts
+; RUN: llc < %s -mtriple=x86_64-pc-linux -mcpu=corei7 -relocation-model=pic | FileCheck %s
----------------
I don't think we need this REQUIRES asserts. The test will pass as is without assertions, right?


http://reviews.llvm.org/D19409





More information about the llvm-commits mailing list