[PATCH] D14117: [mips][microMIPS] Implement APPEND, BPOSGE32C, MODSUB, MULSA.W.PH and MULSAQ_S.W.PH instructions
Simon Dardis via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 25 03:55:31 PDT 2016
sdardis added a subscriber: sdardis.
sdardis accepted this revision.
sdardis added a reviewer: sdardis.
sdardis added a comment.
This revision is now accepted and ready to land.
LGTM with one nit: you should add an invalid test case for APPEND, MULSA.W.PH and MULSAQ_S.W.PH. For append you want to be testing that that the out of range immediates are rejected and for the muls, that the first operand is rejected if it is a GPR and that the other operands are GPRs.
http://reviews.llvm.org/D14117
More information about the llvm-commits
mailing list