[PATCH] D18751: [MachineCombiner] Support for floating-point FMA on ARM64

[Gerolf Hoflehner via llvm-commits]

Gerolf marked an inline comment as done.
Gerolf added a comment.

Thanks, Quentin! I should have addressed all your concerns.


================
Comment at: include/llvm/CodeGen/SelectionDAGTargetInfo.h:145
@@ +144,3 @@
+  virtual bool GenerateFMAsInMachineCombiner(CodeGenOpt::Level OptLevel) const {
+    return false;
+  }
----------------
Gerolf wrote:
> Done.
That should have been Agree. TBD.

================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:89
@@ -87,2 +88,3 @@
     SelectionDAG &DAG;
+    const SelectionDAGTargetInfo &STI;
     const TargetLowering &TLI;
----------------
Gerolf wrote:
> No preference either. I just made it look like TLI and expect more accesses to come.
For the record I removed the field and access it through the DAG. It turned out that the field for some target could result in a null reference.


http://reviews.llvm.org/D18751