[PATCH] D19404: Reorganize GlobalValueSummary with a "Flags" bitfield.

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 23 20:10:01 PDT 2016


tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

One suggestion for comment below.


================
Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:724
@@ +723,3 @@
+                                                            uint64_t Version) {
+  // Summary were not emitted before LLVM 3.9, we don't need to upgrade Linkage
+  // like getDecodedLinkage() above. Any future change to the linkage enum and
----------------
Like the new comment. Could you put the same thing in getEncodedGVSummaryFlags?


http://reviews.llvm.org/D19404





More information about the llvm-commits mailing list