[PATCH] D19462: [ThinLTO] Remove GlobalValueInfo class from index

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 23 19:38:57 PDT 2016


tejohnson added a comment.

In http://reviews.llvm.org/D19462#410132, @joker.eph wrote:

> Looks like a good cleanup!
>
> Could we change the references in the bitcode from being "offset based" to be an "id" (simple increment)?


I think that would be a good idea to make things more consistent between the permodule and combined indexes. I was just looking at that, and it is straightforward, but I'd prefer to do that as a follow on (can do that right after this one goes in). It will mean changing the bitcode format (remove the summary offset from the combined VST entries and adding a value id to the combined summary entries), and I'd prefer to keep this change just to the internal data structures and not mix in bitcode changes in the same patch. Does that sound ok?


http://reviews.llvm.org/D19462





More information about the llvm-commits mailing list