[PATCH] D19454: Store and emit original name in combined index

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 23 17:11:41 PDT 2016


joker.eph marked an inline comment as done.

================
Comment at: test/Bitcode/thinlto-function-summary-originalnames.ll:15
@@ +14,3 @@
+; COMBINED-NEXT:  <VALUE_SYMTAB
+; COMBINED-NEXT:   <COMBINED_GVDEFENTRY {{.*}} op2=5130707953770761057/>
+; COMBINED-NEXT:   <COMBINED_GVDEFENTRY {{.*}} op2=-8709959634447057722/>
----------------
joker.eph wrote:
> tejohnson wrote:
> > These GUIDs (not the original ones above) might be dangerous to put here as they include the path to the module (which I believe could vary on some bots).
> Good point.
I added them back, after defining the "source_filename" in the IR.
It turns out that the order of the entries in the GLOBALVAL_SUMMARY_BLOCK are dependent on the path as well, so the test with the -NEXT lines was broken.


http://reviews.llvm.org/D19454





More information about the llvm-commits mailing list