[PATCH] D19454: Store and emit original name in combined index

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 23 16:38:25 PDT 2016


tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

LGTM, except I have one concern about the test, noted below.


================
Comment at: test/Bitcode/thinlto-function-summary-originalnames.ll:15
@@ +14,3 @@
+; COMBINED-NEXT:  <VALUE_SYMTAB
+; COMBINED-NEXT:   <COMBINED_GVDEFENTRY {{.*}} op2=5130707953770761057/>
+; COMBINED-NEXT:   <COMBINED_GVDEFENTRY {{.*}} op2=-8709959634447057722/>
----------------
These GUIDs (not the original ones above) might be dangerous to put here as they include the path to the module (which I believe could vary on some bots).


http://reviews.llvm.org/D19454





More information about the llvm-commits mailing list