[PATCH] D19454: Store and emit original name in combined index

[Teresa Johnson via llvm-commits]

tejohnson added inline comments.

================
Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:5718
@@ -5702,1 +5717,3 @@
+      ValueIdToCallGraphGUIDMap[ValueID] =
+          std::make_pair(GlobalValGUID, GlobalValGUID);
       break;
----------------
Maybe a comment here and in the below case that for the combined index the original name comes from a separate bitcode record (which is why both are set to the same GUID)?

================
Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:5970
@@ +5969,3 @@
+      auto GUID = getGUIDFromValueId(ValueID);
+      FS->setOriginalName(GUID.second);
+      auto *Info = TheIndex->getGlobalValueInfo(GUID.first);
----------------
Don't FS_ALIAS and FS_PERMODULE_GLOBALVAR_INIT_REFS need to setOriginalName as well?


http://reviews.llvm.org/D19454