[PATCH] D17864: [PGO] Promote indirect calls to conditional direct calls with value-profile

Rong Xu via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 23 10:36:37 PDT 2016


xur updated this revision to Diff 54784.
xur added a comment.

Integrated David's comments.
(1) it turned out we don't need new interface for castIsValid. I now use the existing isBitCastable()
(2) I was able to fold insertCallRetCast() to createDirectCallInst() which make code more compact.
I have to add a reference parameter in createDirCallInst() as I need to use both the direct-call instruction and the bitcast instruction.

Thanks,

-Rong


http://reviews.llvm.org/D17864

Files:
  include/llvm/InitializePasses.h
  include/llvm/LinkAllPasses.h
  include/llvm/Transforms/Instrumentation.h
  lib/Transforms/IPO/PassManagerBuilder.cpp
  lib/Transforms/Instrumentation/CMakeLists.txt
  lib/Transforms/Instrumentation/IndirectCallPromotion.cpp
  lib/Transforms/Instrumentation/Instrumentation.cpp
  test/Transforms/PGOProfile/icp_covariant_return.ll
  test/Transforms/PGOProfile/icp_invoke.ll
  test/Transforms/PGOProfile/icp_mismatch_msg.ll
  test/Transforms/PGOProfile/icp_vararg.ll
  test/Transforms/PGOProfile/indirect_call_promotion.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D17864.54784.patch
Type: text/x-patch
Size: 46186 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160423/0f571a0a/attachment-0001.bin>


More information about the llvm-commits mailing list