[PATCH] D19440: [GVN] Do local FRE for unordered atomic loads

[Mandeep Singh Grang via llvm-commits]

mgrang added a subscriber: mgrang.

================
Comment at: lib/Transforms/Scalar/GVN.cpp:1308
@@ +1307,3 @@
+
+    // Can't forward from non-atomic to atomic without violating memory model
+    if (S->isAtomic() < LI->isAtomic())
----------------
Comment is missing a period (.) at the end.

================
Comment at: lib/Transforms/Scalar/GVN.cpp:1324
@@ -1318,1 +1323,3 @@
 
+    // Can't forward from non-atomic to atomic without violating memory model
+    if (LD->isAtomic() < LI->isAtomic())
----------------
Comment is missing a period (.) at the end.

================
Comment at: lib/Transforms/Scalar/GVN.cpp:1774
@@ -1759,2 +1773,3 @@
 
-  if (!L->isSimple())
+  // This code hasn't been auditted for ordered or volatile memory access
+  if (!L->isUnordered())
----------------
Comment is missing a period (.) at the end.


http://reviews.llvm.org/D19440