[PATCH] D19411: [esan] EfficiencySanitizer libc interceptors

Derek Bruening via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 22 14:05:31 PDT 2016


bruening added inline comments.

================
Comment at: lib/esan/esan_interceptors.cpp:177
@@ +176,3 @@
+#if SANITIZER_LINUX && !SANITIZER_ANDROID
+INTERCEPTOR(int, stat64, const char *path, void *buf) {
+  void *ctx;
----------------
aizatsky wrote:
> should xstat64, lstat, lstat64 interceptors be structured the same way as stat?
Not for xstat64 or lstat64, no: they are simply not present on FreeBSD or Android so there is no #else.  As to the !FreeBSD check of msan vs the !Android check of tsan, I suppose both should be there.

For lstat + __lxstat, yes, that does look like a similar thing to stat + __xstat.


http://reviews.llvm.org/D19411





More information about the llvm-commits mailing list