[PATCH] D19421: [RewriteStatepointsForGC] Stabilise rematerialization order

[Sanjoy Das via llvm-commits]

sanjoy requested changes to this revision.
sanjoy added a comment.
This revision now requires changes to proceed.

Hi Igor,

I had something different in mind: I'd have preferred a systematic
"deterministic by construction" approach, not "at a certain point,
stabilize the order to something quasi-deterministic".  For instance,
I think you're still relying on pointer comparison in `order_by_name`
for unnamed values.

I'd prefer that we figure out why there is any non-determinism in the
first place (e.g. one suspicious bit is that `StatepointLiveSetTy` is
a `DenseSet`, perhaps it should be a `SetVector`?), fix those sources
of non-determinism and ultimately get rid of these stabilization steps
altogether.

Does that sound reasonable?


http://reviews.llvm.org/D19421