[PATCH] D19061: [ARM] Add support for the X asm constraint

Fri Apr 22 13:42:47 PDT 2016

rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.

Hi Silviu,

I'm ok with this approach, since it's simple and seems to cover the cases pretty well. I'm guessing that the error message when the prediction goes wrong is "invalid constraint for asm operand", which is *much* better than a segfault. Also, confusion around macros are really the user's fault for writing such an egregious code in the first place.

It'd be good if James could have a final look, but I'm ok with the change.

cheers,
--renato

================
Comment at: test/CodeGen/ARM/inlineasm-X-constraint.ll:4
@@ +3,3 @@
+; CHECK-LABEL: f1
+; CHECK: vmsr fpscr
+; CHECK: vadd.f64
----------------
shouldn't you verify that the register used in vmsr is also used in vadd?

Same comment for other CHECK lines below.

http://reviews.llvm.org/D19061