[PATCH] D19423: [test-suite] Make unique name generation more robust.

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 22 13:19:35 PDT 2016


MatzeB added a comment.

In http://reviews.llvm.org/D19423#409448, @tra wrote:

> How about adding llvm_test_name_prefix() which would add given prefix to all targets generated within scope?
>  Default will remain empty, but for testsuites that have name clashes it would provide an easy way to make their names unique.
>  Or we can even require having prefix set before we call llvm_multisource(). With that in place we can remove unique name magic and error out on name clashes.


Yep that's what I had in mind. Though I think using a variable like `TARGET_PREFIX` instead of a function would be more in-line with the current way the singlesource()/multisource() are configured.


http://reviews.llvm.org/D19423





More information about the llvm-commits mailing list