[lld] r267200 - Update an out of date comment.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 22 12:56:47 PDT 2016


Author: pcc
Date: Fri Apr 22 14:56:45 2016
New Revision: 267200

URL: http://llvm.org/viewvc/llvm-project?rev=267200&view=rev
Log:
Update an out of date comment.

Modified:
    lld/trunk/ELF/SymbolTable.cpp

Modified: lld/trunk/ELF/SymbolTable.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/SymbolTable.cpp?rev=267200&r1=267199&r2=267200&view=diff
==============================================================================
--- lld/trunk/ELF/SymbolTable.cpp (original)
+++ lld/trunk/ELF/SymbolTable.cpp Fri Apr 22 14:56:45 2016
@@ -336,13 +336,12 @@ void SymbolTable<ELFT>::addMemberFile(Sy
   // available if a strong undefined symbol shows up afterwards in the link.
   // If a strong undefined symbol never shows up, this lazy symbol will
   // get to the end of the link and must be treated as the weak undefined one.
-  // We set UsedInRegularObj in a similar way to what is done with shared
-  // symbols and copy information to reduce how many special cases are needed.
+  // We already marked this symbol as used when we added it to the symbol table,
+  // but we also need to preserve its binding and type.
   if (Undef->isWeak()) {
+    // FIXME: Consider moving these members to Symbol.
     L->Binding = Undef->Binding;
     L->Type = Undef->Type;
-
-    // FIXME: Do we need to copy more?
     return;
   }
 




More information about the llvm-commits mailing list