[lld] r267183 - ELF: Move Visibility, IsUsedInRegularObj and MustBeInDynSym flags to Symbol.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 22 12:15:48 PDT 2016


>    // We set UsedInRegularObj in a similar way to what is done with shared
>    // symbols and copy information to reduce how many special cases are needed.
>    if (Undef->isWeak()) {
> -    L->setUsedInRegularObj();

The comment is now out of date. Could you please update it to say why
you don't need to set it? :-)

Thanks a lot for doing this. At some point we should experiment with
moving all the info to Symbol. There are fewer symbols than
SymbolBodies and they are "closer" to the symbol table.

Cheers,
Rafael


More information about the llvm-commits mailing list