[PATCH] D19417: Use gcc's rules for parsing gcc-style response files
Paul Robinson via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 22 11:55:49 PDT 2016
probinson added a subscriber: probinson.
probinson added a comment.
In principle it's hard to disagree but this might be a backward-compatibility problem for PS4 (Windows hosted but using gcc style driver). At this point I honestly can't remember what our story is for response files. :-) but might not have a chance to investigate until Monday. Would you mind holding off just a bit?
================
Comment at: lib/Support/CommandLine.cpp:535
@@ -536,4 +534,3 @@
- // Backslashes can escape backslashes, spaces, and other quotes. Otherwise
- // they are literal. This makes it much easier to read Windows file paths.
- if (I + 1 < E && Src[I] == '\\' && isGNUSpecial(Src[I + 1])) {
+ // Backslashe escapes the next character.
+ if (I + 1 < E && Src[I] == '\\') {
----------------
Typo
http://reviews.llvm.org/D19417
More information about the llvm-commits
mailing list