[PATCH] D19423: [test-suite] Make unique name generation more robust.

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 22 11:50:20 PDT 2016


MatzeB added a comment.

While the patch looks good to me, what about the alternative approach of just error out on a name clash? AFAIK the only clash we have is between SingleSource/Benchmarks/Shootout and SingleSource/Benchmarks/Shootout-C++ and I'd rather go for a low-tech solution like allowing to specify a prefix in the shootout CMakeFiles and throw an error on non-unique targets instead of going through all the trouble to automatically create unique names.


http://reviews.llvm.org/D19423





More information about the llvm-commits mailing list