[PATCH] D19400: ELF: Move Visibility, IsUsedInRegularObj and MustBeInDynSym flags to Symbol.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 22 11:42:13 PDT 2016


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.


================
Comment at: ELF/SymbolTable.cpp:281
@@ +280,3 @@
+    return !B->CanOmitFromDynSym;
+  } else {
+    // Make sure we preempt DSO symbols with default visibility.
----------------
Remove else after return.


http://reviews.llvm.org/D19400





More information about the llvm-commits mailing list