[PATCH] D19389: [LTO] Create Undefined Bitcode symbol when we drop a comdat member

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 22 11:27:39 PDT 2016


rafael accepted this revision.
rafael added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.


================
Comment at: ELF/InputFiles.cpp:522
@@ -519,1 +521,3 @@
+
+static void setBodyFlags(SymbolBody *Body, const GlobalValue *GV) {
   // FIXME: Expose a thread-local flag for module asm symbols.
----------------
This helper doesn't help much. Please inline it.


http://reviews.llvm.org/D19389





More information about the llvm-commits mailing list