[llvm] r267104 - Use std::move on the enum to insert it into the pair to please MSVC

Mehdi Amini via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 22 11:00:38 PDT 2016


Yes it does: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/3874/steps/build/logs/stdio

Let me know if you figure...

-- 
Mehdi


> On Apr 22, 2016, at 10:57 AM, David Blaikie <dblaikie at gmail.com> wrote:
> 
> Got a link to the buildbot log/failure? That does seem pretty weird.
> 
> On Thu, Apr 21, 2016 at 9:45 PM, Mehdi Amini via llvm-commits <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
> Author: mehdi_amini
> Date: Thu Apr 21 23:45:57 2016
> New Revision: 267104
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=267104&view=rev <http://llvm.org/viewvc/llvm-project?rev=267104&view=rev>
> Log:
> Use std::move on the enum to insert it into the pair to please MSVC
> 
> (I have no idea why is it needed)
> Fixup for r267103
> 
> From: Mehdi Amini <mehdi.amini at apple.com <mailto:mehdi.amini at apple.com>>
> 
> Modified:
>     llvm/trunk/lib/Object/IRObjectFile.cpp
> 
> Modified: llvm/trunk/lib/Object/IRObjectFile.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Object/IRObjectFile.cpp?rev=267104&r1=267103&r2=267104&view=diff <http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Object/IRObjectFile.cpp?rev=267104&r1=267103&r2=267104&view=diff>
> ==============================================================================
> --- llvm/trunk/lib/Object/IRObjectFile.cpp (original)
> +++ llvm/trunk/lib/Object/IRObjectFile.cpp Thu Apr 21 23:45:57 2016
> @@ -40,7 +40,7 @@ IRObjectFile::IRObjectFile(MemoryBufferR
>    Mang.reset(new Mangler());
>    CollectAsmUndefinedRefs(*M, [this](StringRef Name,
>                                       BasicSymbolRef::Flags Flags) {
> -    AsmSymbols.push_back(std::make_pair<std::string, uint32_t>(Name, Flags));
> +    AsmSymbols.push_back(std::make_pair<std::string, uint32_t>(Name, std::move(Flags)));
>    });
>  }
> 
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits>
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160422/e63aab98/attachment.html>


More information about the llvm-commits mailing list