[PATCH] D19189: Expose the list of available features in MCSubtargetInfo

[Michael Kuperstein via llvm-commits]

mkuper added a comment.

Sorry for the delay,
I don't think I'm the right person to review this, I'm not really an expert on MC, the reason my name is all over MCSTI it is because I had to change the underlying data structure for the bits.

In any case, my 2 cents is that this doesn't seem right. I don't think we want to expose SubtargetFeatureKV externally. Perhaps it would be better to be able to query MCSubtargetInfo for a feature directly - similarly to the way we do ToggleFeature today.

A separate issue is that I don't know what the policy is about adding interfaces to MC that aren't used by anything in-tree. That is, I'm not even sure MCSubtargetInfo is intended to interact with FEs. This is a question for grosbach.


http://reviews.llvm.org/D19189