[PATCH] D19418: Fix comment about Intr*Mem properties

Nicolai Hähnle via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 22 09:33:40 PDT 2016


nhaehnle created this revision.
nhaehnle added reviewers: uabelho, joker.eph, reames.
nhaehnle added a subscriber: llvm-commits.

Follow up to D19291: it now makes sense to use two Intr*Mem properties,
in particular IntrReadMem + IntrArgMemOnly is common.

Pointed out by Mikael Holmén.

http://reviews.llvm.org/D19418

Files:
  include/llvm/IR/Intrinsics.td

Index: include/llvm/IR/Intrinsics.td
===================================================================
--- include/llvm/IR/Intrinsics.td
+++ include/llvm/IR/Intrinsics.td
@@ -19,9 +19,7 @@
 
 class IntrinsicProperty;
 
-// Intr*Mem - Memory properties.  An intrinsic is allowed to have at most one of
-// these properties set.  They are listed from the most aggressive (best to use
-// if correct) to the least aggressive.  If no property is set, the worst case
+// Intr*Mem - Memory properties.  If no property is set, the worst case
 // is assumed (it may read and write any memory it can get access to and it may
 // have other side effects).
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D19418.54670.patch
Type: text/x-patch
Size: 650 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160422/a3586692/attachment-0001.bin>


More information about the llvm-commits mailing list