[PATCH] D16676: [mips][microMIPS] Add CodeGen support for SUBU16, SUB, SUBU, DSUB and DSUBU instructions
Simon Dardis via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 22 07:16:53 PDT 2016
sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.
LGTM with one very important point.
hvarga has changed the definition of a tablegen class in http://reviews.llvm.org/D19354, so you'll need to make a similar change for SUBU16_MMR6_DESC that was done for ADDU16_MMR6_DESC. Otherwise the instruction selection table is ordered suboptimially and subu16 cannot be chosen.
Thanks.
http://reviews.llvm.org/D16676
More information about the llvm-commits
mailing list