[PATCH] D19378: [mips] Fix select patterns for MIPS64

Fri Apr 22 05:57:47 PDT 2016

dsanders accepted this revision.
dsanders added a comment.

Well spotted. LGTM with the changes Vasileios requested and an indentation nit.

In http://reviews.llvm.org/D19378#408112, @sdardis wrote:

> Forgot llvm-commits the last time.

Normally you should abandon the patch and re-submit with llvm-commits CC'd. This is because the commit message and patch aren't sent to the mailing list unless it's CC'd from the start.

================
Comment at: test/CodeGen/Mips/llvm-ir/select-int.ll:196-197
@@ +195,4 @@
+  ; SEL-64:     sltu    $1, $zero, $1
+  ; SEL-64:	sll     $1, $1, 0
+  ; SEL-64:	seleqz  $2, $4, $1
+
----------------
Indentation

Repository:
  rL LLVM

http://reviews.llvm.org/D19378