[PATCH] D16452: [mips][microMIPS] AUI, DBITSWAP, LDPC, LLDX, DLSA, LWUPC, SCDX instructions

Simon Dardis via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 22 05:14:31 PDT 2016


sdardis added a subscriber: sdardis.
sdardis requested changes to this revision.
sdardis added a reviewer: sdardis.
sdardis added a comment.
This revision now requires changes to proceed.

The LLX/SCX family of instructions are being changed, so they can be dropped from this patch.

You should retitle this patch to reflect that you're adding tests for aui, rather than implementing it.

Can you rebase and repost?


================
Comment at: lib/Target/Mips/MicroMips64r6InstrInfo.td:111
@@ +110,3 @@
+  list<dag> Pattern = [];
+}
+
----------------
Needs MayLoad = 1.

================
Comment at: lib/Target/Mips/MicroMips64r6InstrInfo.td:125
@@ +124,3 @@
+  list<dag> Pattern = [];
+}
+
----------------
Needs mayLoad = 1

================
Comment at: lib/Target/Mips/Mips64r6InstrInfo.td:96
@@ -94,3 +95,3 @@
 def DDIVU : DDIVU_ENC, DDIVU_DESC, ISA_MIPS64R6;
 def DLSA_R6 : DLSA_R6_ENC, DLSA_R6_DESC, ISA_MIPS64R6;
 def DMOD : DMOD_ENC, DMOD_DESC, ISA_MIPS64R6;
----------------
DLSA also needs to have the NotInMicroMips predicate.


http://reviews.llvm.org/D16452





More information about the llvm-commits mailing list