[PATCH] D19407: [SafeStack] [SSP] Use llvm.stackguard intrinsic.

Marcin Koƛcielnicki via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 22 03:58:31 PDT 2016


koriakin added a comment.

One thing I really don't like here is the necessity of calling insertSSPDeclarations - that should be handled by whoever is expanding the intrinsic. Eg. the following:

  define i8 *@foo() {
          %1 = call i8* @llvm.stackguard();
          ret i8 *%1;
  }
  
  declare i8* @llvm.stackguard() nounwind;

currently segfaults llc on x86_64-freebsd, since it lacks __stack_chk_guard declaration.  However, I don't really know where to add these global variables - the Module is const in SelectionDAGBuilder, where we expand the intrinsics.  Any hints?


Repository:
  rL LLVM

http://reviews.llvm.org/D19407





More information about the llvm-commits mailing list