[PATCH] D19172: New optimization bisect implementation (now modeled on optnone handling)

[Vedant Kumar via llvm-commits]

vsk added a subscriber: vsk.
vsk added a comment.

Hi Andrew, we saw an ASan failure after this landed. I've temporarily reverted r267022 to get our bots going again.


================
Comment at: llvm/trunk/lib/Transforms/IPO/FunctionAttrs.cpp:1001
@@ -997,3 +1000,3 @@
   // always cached.
   TargetLibraryInfo &TLI = *MAM.getCachedResult<TargetLibraryAnalysis>(M);
 
----------------
When `TLI` isn't cached, we end up with:

```
; CHECK-CGSCC-PASS: BISECT: running pass (2) PostOrderFunctionAttrsPass on SCC (f3)
                    ^
<stdin>:2:1: note: scanning from here
/Users/buildslave/jenkins/sharedspace/clang-stage2-cmake-RgSan at 2/llvm/lib/Transforms/IPO/FunctionAttrs.cpp:1001:28: runtime error: reference binding to null pointer of type 'typename TargetLibraryAnalysis::Result' (aka 'llvm::TargetLibraryInfo')
^
<stdin>:12:55: note: possible intended match here
8 opt 0x0000000103e06b82 llvm::detail::PassModel<llvm::LazyCallGraph::SCC, llvm::PostOrderFunctionAttrsPass, llvm::PreservedAnalyses, true>::run(llvm::LazyCallGraph::SCC&, llvm::AnalysisManager<llvm::LazyCallGraph::SCC>&) + 66
```
(http://lab.llvm.org:8080/green/job/clang-stage2-cmake-RgSan_check/1549)

Unfortunately I'm not sure how much this has to do with your patch, since the FIXME has been in place for a while.


Repository:
  rL LLVM

http://reviews.llvm.org/D19172