[PATCH] D19401: MachineScheduler: Fully compare top/bottom candidates

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 21 19:51:45 PDT 2016


MatzeB added a comment.

Note that this is an early review. While the change improves many situations and a bunch of the testcases I fixed even show fewer spills/reloads than before, I cannot commit this yet, because we systematically get many tests on AMDGPU "wrong" because latency in the bottom schedule boundary trumps everything else (the nodes are in the pending queue and not subject to tryCandidate). This leads to unnecessary violation of weak edges where one of the two linked nodes is still in the pending queue. Previously we would accidentally get this right because we would schedule the weak edges correctly from the top...


Repository:
  rL LLVM

http://reviews.llvm.org/D19401





More information about the llvm-commits mailing list