[PATCH] D19395: [sancov] using normalized filenames for blacklist checks.

[Mike Aizatsky via llvm-commits]

aizatsky added inline comments.

================
Comment at: test/tools/sancov/blacklist.test:2
@@ -1,2 +1,3 @@
 REQUIRES: x86_64-linux
-RUN: sancov -covered-functions -blacklist %p/Inputs/blacklist.txt %p/Inputs/test-linux_x86_64 %p/Inputs/test-linux_x86_64.0.sancov | FileCheck %s
+RUN: sancov -covered-functions -blacklist %p/Inputs/fun_blacklist.txt %p/Inputs/test-linux_x86_64 %p/Inputs/test-linux_x86_64.0.sancov | FileCheck %s
+RUN: sancov -covered-functions -blacklist %p/Inputs/src_blacklist.txt %p/Inputs/test-linux_x86_64 %p/Inputs/test-linux_x86_64.1.sancov | FileCheck --check-prefix=CHECK1 %s
----------------
vitalybuka wrote:
> looks like you didn't change name of file itself above: test/tools/sancov/Inputs/blacklist.txt, but was changed here. Is it intended.
Fabricator says the file was correctly renamed:

test/tools/sancov/Inputs/blacklist.txt
This file was moved to test/tools/sancov/Inputs/fun_blacklist.txt.
test/tools/sancov/Inputs/fun_blacklist.txt
This file was moved from test/tools/sancov/Inputs/blacklist.txt.

Here's my git diff:

$ git diff "HEAD^1" "HEAD"
diff --git a/test/tools/sancov/Inputs/blacklist.txt b/test/tools/sancov/Inputs/fun_blacklist.txt
similarity index 100%
rename from test/tools/sancov/Inputs/blacklist.txt
rename to test/tools/sancov/Inputs/fun_blacklist.txt
...


http://reviews.llvm.org/D19395