[PATCH] D19347: Enable stack-use-after-scope tests

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 21 14:15:42 PDT 2016


vitalybuka requested a review of this revision.

================
Comment at: test/asan/TestCases/use-after-scope-dtor-order.cc:11
@@ -10,3 +10,3 @@
     // CHECK: ERROR: AddressSanitizer: stack-use-after-scope
-    // CHECK:  #0 0x{{.*}} in IntHolder::~IntHolder{{.*}}use-after-scope-dtor-order.cc:[[@LINE-2]]
+    // CHECK:  #0 0x{{.*}} in IntHolder::~IntHolder{{.*}}.cc:[[@LINE-2]]
   }
----------------
eugenis wrote:
> why are you removing the file name?
Probability that we hit same function and line number but in different filename is minimal.
So filename is redundant here.
My understanding is that these are tests for the check, but not for output format. So we should limit hard-coding output format and check only essential stuff.


http://reviews.llvm.org/D19347





More information about the llvm-commits mailing list