[PATCH] D19300: delete the llvm.expect intrinsic and its lowering pass

[David Li via llvm-commits]

davidxl added inline comments.

================
Comment at: lib/IR/AutoUpgrade.cpp:664
@@ +663,3 @@
+      // The expect intrinsic always lowered to its first argument.
+      // TODO: We could create the appropriate metadata here to better support
+      // legacy code?
----------------
Is there a reason not to upgrade it properly with meta data?

Another question for deprecation, can you just remove the documentation and leave the support for the intrinsic support for now?


http://reviews.llvm.org/D19300