[PATCH] D18751: [MachineCombiner] Support for floating-point FMA on ARM64

Quentin Colombet via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 21 11:05:01 PDT 2016


qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

Hi Gerolf,

LGTM for the non-target, non-machine combiner changes.

Make sure to follow LLVM coding style (the few things I’ve highlighted previously) and please run opt -instnamer on the test cases.

Cheers,
-Quentin


================
Comment at: include/llvm/Target/TargetInstrInfo.h:824
@@ +823,3 @@
+  /// \param Pattern - combiner pattern
+  virtual bool isThroughputPattern(MachineCombinerPattern Pattern) const;
+
----------------
For the sake of history summarizing the discussion Gerolf and I had offline.
Long term, we should be smart enough to compute this information by ourselves using the scheduling model. To move forward in the meantime, we have this hook to have the targets emulate that with their own heuristics.


http://reviews.llvm.org/D18751





More information about the llvm-commits mailing list