[PATCH] D19138: [X86] Enable the post-RA-scheduler for 32-bit cpus

Amjad Aboud via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 21 09:06:48 PDT 2016


aaboud added inline comments.

================
Comment at: lib/Target/X86/X86.td:290
@@ +289,3 @@
+
+def : ProcessorModel<"pentium-m", GenericPostRAModel,
+                     [FeatureX87, FeatureSlowUAMem16, FeatureMMX,
----------------
Can you create a class for GenereicPostRAModel, similar to class Proc, something like this:

class ProcPostRA<string Name, list<SubtargetFeature> Features>
 : ProcessorModel<Name, GenereicPostRAModel, Features>;

================
Comment at: test/CodeGen/X86/pr16360.ll:2
@@ -1,3 +1,3 @@
 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
 ; RUN: llc < %s -mcpu=pentium4 -mtriple=i686-pc-linux | FileCheck %s
 
----------------
Why did not you simply add the "-post-RA-scheduler=false" flag like in other tests?


http://reviews.llvm.org/D19138





More information about the llvm-commits mailing list