[PATCH] D19330: Refactor implied condition logic from ValueTracking directly into CmpInst. NFC.

[Chad Rosier via llvm-commits]

mcrosier added a comment.

In http://reviews.llvm.org/D19330#407408, @sanjoy wrote:

> Given that this passes all the checked in tests then I'm okay signing off on this for now (with a FIXME stating what remains to be done); but depending on how much time you're willing to commit here, I think we can make this code more comprehensive.  I've added a comment inline about some of the missing cases, but there is a useful litmus test here:  we should be able to implement `isFalseWhenOperandsMatch(X, Y)` exactly as `isTrueWhenOperandsMatch(X, getInversePredicate(Y))`.  Any situation where that doesn't work is a missing case.


Yes, the code can be more comprehensive.  I'll post a patch shortly and I'd like for this work to be complete.  Thanks, Sanjoy.


Repository:
  rL LLVM

http://reviews.llvm.org/D19330