[PATCH] D19167: [esan] EfficiencySanitizer instrumentation pass
Filipe Cabecinhas via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 21 05:43:28 PDT 2016
filcab added inline comments.
================
Comment at: lib/Transforms/Instrumentation/EfficiencySanitizer.cpp:323
@@ +322,3 @@
+ return -1;
+ }
+ size_t Idx = countTrailingZeros(TypeSizeBytes);
----------------
Polluting output too much is annoying. Thinking about it, I guess we might hit this on most runs, not just rarely, which makes it less useful.
How about doing something like ASan does in instrumentUnusualSizeOrAlignment?
http://reviews.llvm.org/D19167
More information about the llvm-commits
mailing list