[PATCH] D19224: [Clang][AVX512][BuiltIn] Adding intrinsics of VGATHER{DPS|DPD} , VPGATHER{QD|QQ|DD|DQ} and VGATHERPF{0|1}{DPS|QPS|DPD|QPD} instruction set .

[Igor Breger via llvm-commits]

igorb added inline comments.

================
Comment at: include/clang/Basic/BuiltinsX86.def:1083
@@ -1082,1 +1082,3 @@
 TARGET_BUILTIN(__builtin_ia32_gatherpfqps,  "vUcV8LLivC*IiIi", "", "avx512pf")
+TARGET_BUILTIN(__builtin_ia32_gather3div2df, "V2dV2dvC*V2LLiUci","","avx512vl")
+TARGET_BUILTIN(__builtin_ia32_gather3div2di, "V4iV2LLivC*V2LLiUci","","avx512vl")
----------------
could you please move new  TARGET_BUILTIN before prefetch  , so all prefetch buildins remain in one group.

================
Comment at: lib/Headers/avx512pfintrin.h:29
@@ +28,3 @@
+#ifndef __PFINTRIN_H
+#define __PFINTRIN_H
+
----------------
please change to __AVX512PFINTRIN_H


http://reviews.llvm.org/D19224