[llvm] r266930 - Fix compilation error in r266919.

Evgenii Stepanov via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 20 16:16:04 PDT 2016


No problem.
I was thinking of pinging you on the ML, but for some reason I've
never got an r266919 email from llvm-commits...

On Wed, Apr 20, 2016 at 3:52 PM, Kevin Enderby <enderby at apple.com> wrote:
> Thanks Evgeniy!  I was in a meeting and was just fixing this now.  Glad you beat me to it.
>
> Kev
>
>> On Apr 20, 2016, at 3:44 PM, Evgeniy Stepanov via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>>
>> Author: eugenis
>> Date: Wed Apr 20 17:44:40 2016
>> New Revision: 266930
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=266930&view=rev
>> Log:
>> Fix compilation error in r266919.
>>
>> lib/Object/MachOObjectFile.cpp:53:44: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move]
>>  return malformedError(Obj.getFileName(), std::move(Msg.str()), ECOverride);
>>
>> Modified:
>>    llvm/trunk/lib/Object/MachOObjectFile.cpp
>>
>> Modified: llvm/trunk/lib/Object/MachOObjectFile.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Object/MachOObjectFile.cpp?rev=266930&r1=266929&r2=266930&view=diff
>> ==============================================================================
>> --- llvm/trunk/lib/Object/MachOObjectFile.cpp (original)
>> +++ llvm/trunk/lib/Object/MachOObjectFile.cpp Wed Apr 20 17:44:40 2016
>> @@ -50,7 +50,7 @@ malformedError(std::string FileName, std
>> static Error
>> malformedError(const MachOObjectFile &Obj, Twine Msg,
>>                object_error ECOverride = object_error::parse_failed) {
>> -  return malformedError(Obj.getFileName(), std::move(Msg.str()), ECOverride);
>> +  return malformedError(Obj.getFileName(), Msg.str(), ECOverride);
>> }
>>
>> // FIXME: Replace all uses of this function with getStructOrErr.
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>


More information about the llvm-commits mailing list