[PATCH] D19343: Move PDB parsing code into a library

[Reid Kleckner via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

Looks good. I had some minor comments. Let's see if David has any thoughts on this.


================
Comment at: include/llvm/DebugInfo/PDB/Raw/PDBStream.h:25
@@ +24,3 @@
+
+  std::error_code ReadInteger(uint32_t &Dest);
+  std::error_code ReadZeroString(std::string &Dest);
----------------
Any reason this interface went to leading upper case?

================
Comment at: lib/DebugInfo/PDB/Raw/PDBFile.cpp:11
@@ +10,3 @@
+#include "llvm/DebugInfo/PDB/Raw/PDBFile.h"
+
+#include "llvm/ADT/ArrayRef.h"
----------------
We don't usually separate local includes from other LLVM includes


http://reviews.llvm.org/D19343