[PATCH] D19286: Refine instruction weight annotation algorithm for sample profiler.
David Li via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 20 15:17:02 PDT 2016
davidxl added inline comments.
================
Comment at: lib/Transforms/IPO/SampleProfile.cpp:489
@@ -478,1 +488,3 @@
+ const CallInst *CI = dyn_cast<CallInst>(&Inst);
+ if (CI && findCalleeFunctionSamples(*CI)) R = 0;
}
----------------
move R=0 to newline.
================
Comment at: lib/Transforms/IPO/SampleProfile.cpp:489
@@ -478,1 +488,3 @@
+ const CallInst *CI = dyn_cast<CallInst>(&Inst);
+ if (CI && findCalleeFunctionSamples(*CI)) R = 0;
}
----------------
davidxl wrote:
> move R=0 to newline.
Since this is the else branch which means R already is zero, why do we need to reset it?
http://reviews.llvm.org/D19286
More information about the llvm-commits
mailing list