[PATCH] D19339: Add natvis visualizers for endian packed types

[Zachary Turner via llvm-commits]

zturner created this revision.
zturner added reviewers: aaron.ballman, mspertus.
zturner added a subscriber: llvm-commits.

I only attempt to do unaligned types here, because aligned types start getting pretty ugly.

I don't know if there's a better way to do this.  Let me know if you can think of something cleaner.

http://reviews.llvm.org/D19339

Files:
  utils/LLVMVisualizers/llvm.natvis

Index: utils/LLVMVisualizers/llvm.natvis
===================================================================
--- utils/LLVMVisualizers/llvm.natvis
+++ utils/LLVMVisualizers/llvm.natvis
@@ -168,4 +168,35 @@
       <Item Name="[underlying]" Condition="hasVal">*(($T1 *)(unsigned char *)storage.buffer)</Item>
     </Expand>
   </Type>
+
+  <!-- Since we're in MSVC, we can assume that the system is little endian.  Therefore
+       the little and native cases just require a cast.  Handle this easy case first. Use
+       a wildcard for the second template argument (the endianness), but we will use a
+       specific value of 0 later on for the big endian to give it priority for being a
+       better match.  -->
+  <Type Name="llvm::support::detail::packed_endian_specific_integral<*,*,1>">
+    <DisplayString>little endian {*(($T1*)(unsigned char *)Value.buffer)}</DisplayString>
+    <Expand>
+      <Item Name="[value]">*(($T1*)(unsigned char *)Value.buffer)</Item>
+      <Item Name="[Raw Bytes]" Condition="sizeof($T1)==1">(unsigned char *)Value.buffer,1</Item>
+      <Item Name="[Raw Bytes]" Condition="sizeof($T1)==2">(unsigned char *)Value.buffer,2</Item>
+      <Item Name="[Raw Bytes]" Condition="sizeof($T1)==4">(unsigned char *)Value.buffer,4</Item>
+      <Item Name="[Raw Bytes]" Condition="sizeof($T1)==8">(unsigned char *)Value.buffer,8</Item>
+    </Expand>
+  </Type>
+  
+  <!-- Now handle the hard case of big endian.  We need to do the swizzling here, but
+       we need to specialize it based on the size of the value type. -->
+  <Type Name="llvm::support::detail::packed_endian_specific_integral<*,0,1>">
+    <DisplayString Condition="sizeof($T1)==1">big endian {*(unsigned char *)Value.buffer}</DisplayString>
+    <DisplayString Condition="sizeof($T1)==2">big endian {(($T1)(*(unsigned char *)Value.buffer) << 8) | ($T1)(*((unsigned char *)Value.buffer+1))}</DisplayString>
+    <DisplayString Condition="sizeof($T1)==4">big endian {(($T1)(*(unsigned char *)Value.buffer) << 24) | (($T1)(*((unsigned char *)Value.buffer+1)) << 16) | (($T1)(*((unsigned char *)Value.buffer+2)) << 8) | ($T1)(*((unsigned char *)Value.buffer+3))}</DisplayString>
+    <DisplayString Condition="sizeof($T1)==8">big endian {(($T1)(*(unsigned char *)Value.buffer) << 56) | (($T1)(*((unsigned char *)Value.buffer+1)) << 48) | (($T1)(*((unsigned char *)Value.buffer+2)) << 40) | (($T1)(*((unsigned char *)Value.buffer+3)) << 32) | (($T1)(*((unsigned char *)Value.buffer+4)) << 24) | (($T1)(*((unsigned char *)Value.buffer+5)) << 16) | (($T1)(*((unsigned char *)Value.buffer+6)) << 8) | ($T1)(*((unsigned char *)Value.buffer+7))}</DisplayString>
+    <Expand>
+      <Item Name="[Raw Bytes]" Condition="sizeof($T1)==1">(unsigned char *)Value.buffer,1</Item>
+      <Item Name="[Raw Bytes]" Condition="sizeof($T1)==2">(unsigned char *)Value.buffer,2</Item>
+      <Item Name="[Raw Bytes]" Condition="sizeof($T1)==4">(unsigned char *)Value.buffer,4</Item>
+      <Item Name="[Raw Bytes]" Condition="sizeof($T1)==8">(unsigned char *)Value.buffer,8</Item>
+    </Expand>
+  </Type>
 </AutoVisualizer>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D19339.54406.patch
Type: text/x-patch
Size: 3219 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160420/833aef86/attachment-0001.bin>