[PATCH] D19276: folding compares if pointers do not escape

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 20 12:30:40 PDT 2016


sanjoy accepted this revision.
sanjoy added a comment.
This revision is now accepted and ready to land.

lgtm with one minor nit


================
Comment at: lib/Transforms/InstCombine/InstructionCombining.cpp:1865
@@ -1864,1 +1864,3 @@
 
+static bool isNeverEqualToUnescapedAlloc(Instruction *CmpOp) {
+  switch (CmpOp->getOpcode()) {
----------------
Nit: I'd rename `CmpOp` to just `I` -- the fact that it is a `icmp` operand is not pertinent here.


http://reviews.llvm.org/D19276





More information about the llvm-commits mailing list