[PATCH] D19168: [esan] EfficiencySanitizer base runtime library

Kuba Brecka via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 20 11:29:11 PDT 2016


kubabrecka added inline comments.

================
Comment at: lib/esan/esan.h:38-40
@@ +37,5 @@
+
+void initializeLibrary();
+int finalizeLibrary();
+void processMemAccess(uptr PC, uptr Addr, int Size, bool IsWrite);
+void processUnalignedAccess(uptr PC, uptr Addr, int Size, bool IsWrite);
----------------
All the other sanitizers use capitalized function names (with the first letter capitalized as well).  Can we do this in ESan as well?  E.g. `InitializeLibrary`, `FinalizeLibrary`, `ProcessMemAccess`, etc.


http://reviews.llvm.org/D19168





More information about the llvm-commits mailing list