[PATCH] D19333: Move coverage related code into a separate library

[Easwaran Raman via llvm-commits]

eraman created this revision.
eraman added reviewers: bogner, vsk, davidxl.
eraman added a subscriber: llvm-commits.

Recently, I ran into a circular dependency problem when I made Analysis depend on ProfileData.  See http://lists.llvm.org/pipermail/llvm-dev/2016-April/098400.html for more context. ProfileData has an existing dependence on Analysis through Object and Bitcode. Only the Coverage code depends on Object. Splitting Coverage data into its own library removes the ProfileData->Analysis dependence. Does this seem reasonable?

Notes:
* I have modeled this on Codegen which has some files underneath as well as subdirs that correspond to separate libraries. 
* Clang code that includes coverage headers need to be changed as well. Will send a patch once there is a general agreement on this patch.
* I have used "svn mv" to move coverage related code into the new directory to preserver history.
* I have not split the ProfileData unittest to a separate Coverage directory thinking there will be only one file there, but perhaps that also needs to be split?
*  check-all runs successfully, but it's quite likely that I have overlooked something.

http://reviews.llvm.org/D19333

Files:
  include/llvm/ProfileData/Coverage/CoverageMappingReader.h
  include/llvm/ProfileData/Coverage/CoverageMappingWriter.h
  include/llvm/ProfileData/CoverageMapping.h
  include/llvm/ProfileData/CoverageMappingReader.h
  include/llvm/ProfileData/CoverageMappingWriter.h
  lib/ProfileData/CMakeLists.txt
  lib/ProfileData/Coverage/CMakeLists.txt
  lib/ProfileData/Coverage/CoverageMapping.cpp
  lib/ProfileData/Coverage/CoverageMappingReader.cpp
  lib/ProfileData/Coverage/CoverageMappingWriter.cpp
  lib/ProfileData/Coverage/LLVMBuild.txt
  lib/ProfileData/CoverageMapping.cpp
  lib/ProfileData/CoverageMappingReader.cpp
  lib/ProfileData/CoverageMappingWriter.cpp
  lib/ProfileData/LLVMBuild.txt
  tools/llvm-cov/CMakeLists.txt
  tools/llvm-cov/CodeCoverage.cpp
  tools/llvm-cov/CoverageFilters.h
  tools/llvm-cov/CoverageSummaryInfo.h
  tools/llvm-cov/LLVMBuild.txt
  tools/llvm-cov/SourceCoverageView.h
  unittests/ProfileData/CMakeLists.txt
  unittests/ProfileData/CoverageMappingTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D19333.54301.patch
Type: text/x-patch
Size: 91288 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160420/cfa210f2/attachment.bin>