[PATCH] D19308: ThinLTO: Resolve linkonce_odr aliases just like functions

[Teresa Johnson via llvm-commits]

tejohnson added inline comments.

================
Comment at: lib/LTO/ThinLTOCodeGenerator.cpp:161
@@ +160,3 @@
+      // Alias can't be turned into available_externally.
+      return OriginalLinkage;
+    return GlobalValue::AvailableExternallyLinkage;
----------------
Since this is a variant of similar handling that used to be here for the aliasee in D19096 (since removed), I will copy over a variant of my suggestion from back then:

I think it would be helpful to add a comment here about how this works. I.e. something like "If a non-imported alias that remains linkonce is referenced by an imported function, the IRMover will create a corresponding ExternalLinkage declaration, which will be satisfied at link time with the copy that was resolved to WeakODR."


http://reviews.llvm.org/D19308