[PATCH] D19096: ThinLTO/ModuleLinker: add a flag to not always pull-in linkonce when performing importing

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 20 08:38:18 PDT 2016


tejohnson added inline comments.

================
Comment at: test/Linker/funcimport2.ll:6
@@ -5,3 +5,3 @@
 
-; CHECK: define linkonce_odr hidden void @foo() {
+; CHECK: define available_externally hidden void @foo() {
 define available_externally hidden void @foo() {
----------------
joker.eph wrote:
> tejohnson wrote:
> > Looks like this change should be part of D19308 instead?
> I don't think so: it is testing that we don't import foo (we're still seeing the original definition). So it is not about the resolution in D19308 
Ah, I see. Thought this was testing a linkage change, missed the fact that it is already available_externally in this file.


http://reviews.llvm.org/D19096





More information about the llvm-commits mailing list