[PATCH] D19150: [mips][microMIPS] Implement LL, SC, LWM32, SWM32, MOVEP, ROTR, ROTRV and SYSCALL instructions

Simon Dardis via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 20 07:45:40 PDT 2016


sdardis added a comment.

Sorry, I should have been clearer, when I said "place the instructions in alphabetical order", I mean the instructions you were adding, not the entire test file.

Just place the new tests at the bottom of the test files. Then submit the tests from this diff (54357) as two separate review requests, one containing the invalid/invalid-wrong-error/valid files, and the other with the disassembly tests.

Secondly, you've added tests for swm32 and lwm32. If that's all you're doing can you update the commit message + title to reflect that?

Thanks.


http://reviews.llvm.org/D19150





More information about the llvm-commits mailing list